Ticket #4 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

rpm compilation fails on GNU/Hurd due missing SA_SIGINFO

Reported by: atkac Assigned to: pmatilai
Priority: major Milestone:
Component: rpm Version: RPM Development
Keywords: Cc:

Description

Compilation fails on GNU/Hurd due missing SA_SIGINFO. GNU/Hurd has only "old style" signal API. Proposed patch fixes the problem.

I'm not sure if you want include signal.h directly in rpmsq.h. If yes then it seems SA_SIGINFO conditional building has to be handled through configure & config.h.

Attachments

rpm-sigaction.patch (1.4 kB) - added by atkac on 10/31/08 17:39:30.

Change History

10/31/08 17:39:30 changed by atkac

  • attachment rpm-sigaction.patch added.

11/04/08 08:30:32 changed by pmatilai

  • status changed from new to closed.
  • resolution set to fixed.

Seems reasonable to me. Applied, thanks for the patch.

11/05/08 14:39:35 changed by atkac

  • status changed from closed to reopened.
  • resolution deleted.

Hm, after inspection previous patch was incomplete. Compilation emits those errors: rpmsq.c:159: warning: initialization from incompatible pointer type rpmsq.c:161: warning: initialization from incompatible pointer type rpmsq.c:163: warning: initialization from incompatible pointer type rpmsq.c:165: warning: initialization from incompatible pointer type rpmsq.c:167: warning: initialization from incompatible pointer type rpmsq.c:169: warning: initialization from incompatible pointer type rpmsq.c: In function 'rpmsqEnable': rpmsq.c:276: warning: pointer type mismatch in conditional expression

Problem is in rpmsqAction function. Prototype/definition has to be conditionalized as well:

#ifdef SA_SIGINFO void rpmsqAction(int signum, void * info, void * context); #else void rpmsqAction(int signum); #endif

11/06/08 08:04:38 changed by pmatilai

  • status changed from reopened to closed.
  • resolution set to fixed.

Duh, of course :) Added now...