Ticket #150 (closed defect: fixed)
Opened 6 years ago
Last modified 6 years ago
mimetype provides generator should not process all desktop files
Reported by: stick Assigned to: RpmTickets
Priority: minor Milestone:
Component: rpm Version: RPM Development
Keywords: Cc:
Description
Desktop file specification says:
The MimeType? key is used to indicate the MIME Types that an application knows how to handle. It is expected that for some applications this list could become long. An application is expected to be able to reasonably open files of these types using the command listed in the Exec key.
Therefore RPM should not process all desktop files, but only the ones that have Type=Application set. This could be further enhanced by requiring Exec= line to be present.
Attachments
- rpm.patch (0.7 kB) - added by llunak on 03/17/10 14:43:08.
- rpm 4.7 patch
- 0001-Don-t-process-desktop-files-without-Type-Application.patch (1.0 kB) - added by stick on 03/17/10 15:05:27.
- patch against master
Change History
03/17/10 14:43:08 changed by llunak
- attachment rpm.patch added.
rpm 4.7 patch
03/17/10 14:45:44 changed by llunak
I suggest the attached patch. It would also make sense to filter the locations of *.desktop files that are checked (so that e.g. just example files shipped in a random location are ignored), but I don't know how to make sure that valid files are not ignored by this, as http://standards.freedesktop.org/menu-spec/menu-spec-latest.html doesn't seem to provide an easy and reliable way to find all possible locations of application desktop files.
03/17/10 15:05:27 changed by stick
- attachment 0001-Don-t-process-desktop-files-without-Type-Application.patch added.
patch against master
05/04/10 09:55:36 changed by pmatilai
- status changed from new to closed.
- resolution set to fixed.
Apologies for the delay... the patch against master applied now as it takes Exec presence into account too. Also the .desktop file locations are now filtered in the largely rewritten, pluggable (so things like this could actually be moved out of rpm) file classification system.
Thanks for the patches :)